Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds flushes to the output stream of teamcity reporter,… #1057

Merged
merged 1 commit into from
Oct 17, 2017
Merged

adds flushes to the output stream of teamcity reporter,… #1057

merged 1 commit into from
Oct 17, 2017

Conversation

sgrottel
Copy link
Contributor

… making the test output more responsive.

Description

There is the issue with the teamcity reporter described here:
https://github.com/philsquared/Catch/blob/master/docs/build-systems.md#teamcity-reporter
Tests are only reported after the whole suite is completed.
This can be fixed by explicitly flushing the output stream of the reporter.

I added flush commands to the output functions of the reporter.

Now (long) running tests are reported in Teamcity more quickly, almost as soon as the tests are completed.

If these flushes would create a performance issue, additional code could be added to only flush every some seconds. But in my setup it did not seem necessary.

@horenmar
Copy link
Member

This is a potential issue with streaming reporters in general and we have had to fix it for the XML reporter earlier in the year.

Sadly without NVI-based rework of the reporters, it has to be fixed in each reporter individually.

@horenmar horenmar merged commit c9d9699 into catchorg:master Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants