Improve JUnit failure report #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JUnit report is improved in that: * The message shows the testing condition, not the result * The actual message has similar output than the console one
Codecov Report
@@ Coverage Diff @@
## master #1719 +/- ##
==========================================
+ Coverage 86.22% 88.13% +1.91%
==========================================
Files 131 138 +7
Lines 3832 5494 +1662
==========================================
+ Hits 3304 4842 +1538
- Misses 528 652 +124 |
|
Thanks, I rebased the changes to current master to make it ready for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JUnit report is improved in that:
My reason is that using catch2 with junit reporter in a gitlab testing environment, failures report next to nothing, just the line where the failure happened. So i modified the output to be similar to the console one.
I think this also addresses #1347