Fix Gantt issue when step titles have a colon #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since colon is a mermaid gantt chart separator, having more than one colon breaks mermaid. Not sure if this is a mermaid issue or not following mermaid spec for gantt charts, but it's a simple fix.
rwxdash
approved these changes
Mar 30, 2023
Foresight Summary
View More Details✅ build-workflow-telemetry workflow has finished in 1 minute 42 seconds and finished at 30th Mar, 2023.
*You can configure Foresight comments in your organization settings page. |
|
Thank you for the contribution @tspascoal. @serkan-ozal can you check and merge the PR, please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since colon is a mermaid Gantt chart separator, having more than one colon breaks mermaid, so a step that contains a
:breaks the mermaid Gantt chartNot sure if this is a mermaid issue or not following mermaid spec for gantt charts, but it's a simple fix.
This is a repro of the issue and here we can see the effect of the fix
Closes #35