-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(impl):[#419] hotfix json path dependency #774
Conversation
CHANGELOG file was not updated! Make sure to include important changes. |
|
@@ -113,7 +112,7 @@ void shouldCreateAndCompleteJob() { | |||
.when() | |||
.post("/irs/jobs") | |||
.then() | |||
.statusCode(HttpStatus.CREATED.value()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we use spring-boot-starter-web
in almost every module, does it really matter to remove it from here?
If you think so, then at least use constants for the status, please.
@@ -222,7 +220,7 @@ public void iGetTheJobId() { | |||
.when() | |||
.post("/irs/jobs") | |||
.then() | |||
.statusCode(HttpStatus.CREATED.value()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we use spring-boot-starter-web
in almost every module, does it really matter to remove it from here?
If you think so, then at least use constants for the status and media type, please.
Fixed in spring-boot 3.1.9 that will be fixed on 22.02.2024 spring-projects/spring-boot#39328 |
…ipse-tractusx#639-fix-policy-expired-error-message bug: eclipse-tractusx/traceability-foss#639 update policy expired err…
hotfix json path dependency