Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(impl):[#419] hotfix json path dependency #774

Closed
wants to merge 2 commits into from

Conversation

ds-ext-kmassalski
Copy link

hotfix json path dependency

Copy link

CHANGELOG file was not updated! Make sure to include important changes.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@@ -113,7 +112,7 @@ void shouldCreateAndCompleteJob() {
.when()
.post("/irs/jobs")
.then()
.statusCode(HttpStatus.CREATED.value())

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we use spring-boot-starter-web in almost every module, does it really matter to remove it from here?
If you think so, then at least use constants for the status, please.

@@ -222,7 +220,7 @@ public void iGetTheJobId() {
.when()
.post("/irs/jobs")
.then()
.statusCode(HttpStatus.CREATED.value())

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we use spring-boot-starter-web in almost every module, does it really matter to remove it from here?
If you think so, then at least use constants for the status and media type, please.

@ds-ext-kmassalski
Copy link
Author

ds-pweick referenced this pull request in ds-pweick/tx-item-relationship-service Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants