Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/596 refactoring policystore implementation #1099

Merged
merged 5 commits into from
Mar 20, 2024
Merged

Chore/596 refactoring policystore implementation #1099

merged 5 commits into from
Mar 20, 2024

Conversation

ds-mwesener
Copy link

@ds-mwesener ds-mwesener commented Mar 20, 2024 •
edited by github-actions bot
Loading

github-actions[bot]
github-actions bot suggested changes Mar 20, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a short description of the feature/fix to the Changelog.md.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 20, 2024 •
edited
Loading

Integration Test Results

327 tests   327 ✅  1m 30s ⏱️
 39 suites    0 💤
 39 files      0 ❌

Results for commit 28bc3d0.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 20, 2024 •
edited
Loading

Unit Test Results

208 tests   208 ✅  19s ⏱️
 55 suites    0 💤
 55 files      0 ❌

Results for commit 28bc3d0.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 20, 2024 •
edited
Loading

‼️ Dependency Check findings ‼️

One or more high/critical findings have been found during dependency check. Please check the depenency report:
https://github.com/catenax-ng/tx-traceability-foss/actions/runs/8359908710

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 20, 2024
View reviewed changes
...org/eclipse/tractusx/traceability/assets/domain/asbuilt/service/AssetAsBuiltServiceImpl.java
@Override
protected IrsRepository getIrsRepository() {
return irsRepository;
protected JobRepository getJobRepository() {

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [AbstractAssetBaseService.getJobRepository](1); it is advisable to add an Override annotation.
...eclipse/tractusx/traceability/assets/domain/asplanned/service/AssetAsPlannedServiceImpl.java
@Override
protected IrsRepository getIrsRepository() {
return irsRepository;
protected JobRepository getJobRepository() {

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [AbstractAssetBaseService.getJobRepository](1); it is advisable to add an Override annotation.
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'TX Traceability FOSS frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'Trace-X Root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ds-ext-sceronik
ds-ext-sceronik approved these changes Mar 20, 2024
View reviewed changes
Copy link

@ds-ext-sceronik ds-ext-sceronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM . some Override annotation missing picked up by sonar

@ds-mwesener ds-mwesener merged commit 4e6a6a6 into main Mar 20, 2024
@ds-mwesener ds-mwesener deleted the chore/596-refactoring-policystore-implementation branch March 20, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] requested changes

@ds-ext-sceronik ds-ext-sceronik ds-ext-sceronik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactoring of policies to only use IRSPolicyStore
2 participants
@ds-mwesener @ds-ext-sceronik