Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(whiskers): remove capitalize_hex & update to v2.5.0 #15

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

stenehall
Copy link
Contributor

This replaces the depricated capitalize_hex with hex_format

Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to bump up the version too since it looks like hex_format was only introduced in v2.4.0

@stenehall stenehall force-pushed the remove-depricatd-capitalize_hex branch from 61d0ea1 to c42df43 Compare October 10, 2024 20:24
@stenehall
Copy link
Contributor Author

You'll need to bump up the version too since it looks like hex_format was only introduced in v2.4.0

You're right. My bad. I thought the version in the whiskers block would have warned me if I used something not allowed in that version. But I have 2.5 installed, it was introduced in 2.4 and the file said 2.3. So it seems like there's no built in check for this :).

I bumpbed the version in the files and added it as a separate commit before replacing the depricated capitalize_hex.

@uncenter
Copy link
Member

The whiskers.version property is more like a minimum supported version (MSV). We don't have a list of features/changes/etc stored internally in Whiskers, so we can't warn if you use something that doesn't match the MSV. The version check comes in if you were to set the version to something newer than your local version of Whiskers, like 2.6.0 at the time of writing. If you try to build the file, you should get a compatibility error/warning that the template requires a newer version of Whiskers.

@sgoudham sgoudham changed the title chore: replace depricated capitalize_hex with hex_format build: remove deprecated capitalize_hex & update to v2.5.0 Oct 10, 2024
Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the version!

FWIW, the list of commits in the PR doesn't matter too much as we prefer/require squash commits across the entire organisation when merging.

@sgoudham sgoudham changed the title build: remove deprecated capitalize_hex & update to v2.5.0 build(whiskers): remove capitalize_hex & update to v2.5.0 Oct 10, 2024
@sgoudham sgoudham merged commit bdaa531 into catppuccin:main Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants