tests: add snapshot tests via insta.rs #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgoudham
added a commit
that referenced
this pull request
Sep 21, 2024
* tests: add snapshot tests via insta.rs * ci: set `CI: true` for insta.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves our unit tests all to snapshot tests using insta.rs which should make
it much nicer to review changes to the fixtures.
We can technically refactor the tests more since a lot of it is duplicated and
can be parameterised / macro'd but I didn't want to spend more time on this.
I'll raise a PR in a minute adjusting the colours as discussed on discord.