-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(canvas-lms): rewrite #1084
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: uncenter <[email protected]>
Co-authored-by: uncenter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some unthemed areas I'm noticing:
Assignment status (green text):
Submit/new attempt bar and button at bottom of assignment page:
The bar is also unthemed (probably the same bar but just for example) on assignments without submission:
Apply button on grades page should be normal accent, not sure why it is this dark:
Side bar color:
Dashboard list view notifications indicator and modal:
The notification counter/indicator (marked with an arrow) should be themed, as should the bar under the tabs, as should the notification content.
Web URL submission box:
File upload submission box:
Rubric tables look off because the text has a different background to the table itself:
I was able to use the following CSS to theme all of those little and sometimes big spinners Canvas uses: [class*="spinner__circleTrack"] {
stroke: @surface1 !important;
}
[class*="spinner__circleSpin"] {
stroke: @accent-color !important;
} |
I'm going to add a "waiting-on-author" label - no pressure, just signals to maintainers at a glance that a review is not required yet. Please leave a comment once you believe you have implemented the suggested changes and fixed the unthemed areas :) |
For the assignment-page/upload styles, i don't think canvas.instructure.com nor my school's instance has Enhanced Assignments enabled so I can't get those pages to show up on my end - if I could get some html snippets/css styles for those that'd be greatly appreciated. For sidebar, I left that unstyled because I thought it would help with people who enroll at multiple colleges. Should I just style it according to accent-color? |
I would say make it mantle? |
Pushed some fixes. Not complete yet, and not in the right place lol. Trying to juggle some files with new documentation I plan to introduce to go along with some of the stuff in that commit. If you want you can organize the new enhanced assignments section stuff I added into the right place and I'll keep working on it wherever you move it to when I get back to it. |
(reopening because I didn't name my branch properly, apologies)
🔧 What does this fix? 🔧
Before/After on Catppuccin Mocha with Green accent color
(white borders on the screenshot are my browser not the userstyles)
Dashboard
Before
After
Example Course Homepage
Before
After
Example Quiz
Before
After
Example Course Modules
Before
After
I've themed the main pages that I've used as a student during my courses.
A lot of the canvas CSS is autogenerated but with stable suffixes/prefixes/children, hence the high use of attribute selectors and such. edit: apologies for the large line count increase, styling the site properly is a pain.
🗒 Checklist 🗒
==UserStyle==
header of thecatppuccin.user.css
file.readme
temporary update:
Haven't had time to really work on this because I've got finals until 12/17, sorry. If I don't have access to my classes after this I'll setup a canvas class on the main Canvas instance (canvas.instructure.org) to more systematically style the site instead of just styling stuff as I notice it.