Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(roblox): init #1176

Open
wants to merge 95 commits into
base: main
Choose a base branch
from
Open

feat(roblox): init #1176

wants to merge 95 commits into from

Conversation

GenShibe
Copy link
Contributor

@GenShibe GenShibe commented Aug 8, 2024

so i made a bunch of changes, and they do not seem to be appearing on the existing PR. So i have been advised by bell to open a new PR

ThatOneUnoriginal and others added 30 commits March 10, 2024 21:55
…ction since it appears to do nothing anymore.
Unsure if everything related to the Roblox+ extension is supported but the significant features I'm pretty sure are.
@uncenter uncenter marked this pull request as draft September 22, 2024 19:48
@uncenter
Copy link
Member

Thanks for your work on this - I think we can call it good enough at this point, if you can get the linter happy!

@GenShibe GenShibe marked this pull request as ready for review September 26, 2024 19:55
isabelroses
isabelroses previously approved these changes Oct 12, 2024
isabelroses
isabelroses previously approved these changes Oct 17, 2024
Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This banner thing (.home-page-upsell-card-banner-container) I'm getting is unthemed, just needs the background and border color fixed.

CleanShot 2024-10-17 at 07 18 07

When like looking at your profile themed vs unthemed it looks weird in that it has a lot of patches with different background colors, not matching the solidness/single color of the unthemed website.
The cancel and save buttons on your profile are also somewhat unthemed:

CleanShot 2024-10-17 at 07 20 33

Top area of marketplace unthemed:

CleanShot 2024-10-17 at 07 21 26

In general please just go through and click around the website and fix the obvious unthemed / bad looking areas.

@uncenter
Copy link
Member

CleanShot 2024-10-22 at 07 19 51

Sidebar unthemed.

CleanShot 2024-10-22 at 07 20 17

Notifications window.

When like looking at your profile themed vs unthemed it looks weird in that it has a lot of patches with different background colors, not matching the solidness/single color of the unthemed website. The cancel and save buttons on your profile are also somewhat unthemed:

CleanShot 2024-10-17 at 07 20 33

Neither of these are fixed as far as I can tell.

@uncenter
Copy link
Member

Buttons on https://www.roblox.com/bundles/43/Toy-Animation-Pack don't have the correct hover states:

CleanShot 2024-11-10 at 13 22 31

https://www.roblox.com/upgrades/robux

This page could have some minor improvements in background color and text.

And the notifications window and profile page from my last two comments are not fixed either.

@GenShibe
Copy link
Contributor Author

Buttons on https://www.roblox.com/bundles/43/Toy-Animation-Pack don't have the correct hover states:

CleanShot 2024-11-10 at 13 22 31

https://www.roblox.com/upgrades/robux

This page could have some minor improvements in background color and text.

And the notifications window and profile page from my last two comments are not fixed either.

can't seem to replicate the profile page issues oddly enough, and im pretty sure that i fixed the notif window... i'll take a look

@uncenter uncenter added the waiting on author Note for staff that a re-review is not yet required label Nov 10, 2024
@uncenter
Copy link
Member

LMK when everything is fixed.

@uncenter uncenter removed the waiting on author Note for staff that a re-review is not yet required label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants