-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(roblox): init #1176
base: main
Are you sure you want to change the base?
feat(roblox): init #1176
Conversation
Co-authored-by: Isabel <[email protected]>
Co-authored-by: Isabel <[email protected]>
…ction since it appears to do nothing anymore.
Unsure if everything related to the Roblox+ extension is supported but the significant features I'm pretty sure are.
…e was created (ie the text input area)
Thanks for your work on this - I think we can call it good enough at this point, if you can get the linter happy! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This banner thing (.home-page-upsell-card-banner-container
) I'm getting is unthemed, just needs the background and border color fixed.
When like looking at your profile themed vs unthemed it looks weird in that it has a lot of patches with different background colors, not matching the solidness/single color of the unthemed website.
The cancel and save buttons on your profile are also somewhat unthemed:
Top area of marketplace unthemed:
In general please just go through and click around the website and fix the obvious unthemed / bad looking areas.
Sidebar unthemed. Notifications window.
Neither of these are fixed as far as I can tell. |
Buttons on https://www.roblox.com/bundles/43/Toy-Animation-Pack don't have the correct hover states: https://www.roblox.com/upgrades/robux This page could have some minor improvements in background color and text. And the notifications window and profile page from my last two comments are not fixed either. |
can't seem to replicate the profile page issues oddly enough, and im pretty sure that i fixed the notif window... i'll take a look |
LMK when everything is fixed. |
so i made a bunch of changes, and they do not seem to be appearing on the existing PR. So i have been advised by bell to open a new PR