Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(anilist): change text-bright #1458

Merged
merged 7 commits into from
Jan 21, 2025
Merged

fix(anilist): change text-bright #1458

merged 7 commits into from
Jan 21, 2025

Conversation

AnubisNekhet
Copy link
Member

Changes default value of --color-text-bright, removes redundant styling

@github-actions github-actions bot added the anilist AniList, AniChart label Nov 15, 2024
@AnubisNekhet AnubisNekhet marked this pull request as draft November 15, 2024 20:29
@AnubisNekhet AnubisNekhet marked this pull request as ready for review November 15, 2024 20:50
@uncenter uncenter added the waiting on author Note for staff that a re-review is not yet required label Jan 2, 2025
@AnubisNekhet
Copy link
Member Author

I've removed the scrollbar styling entirely since I can't figure out how to make it work without reusing the mixin or using :has(). PR seems good to merge now.

@AnubisNekhet AnubisNekhet requested a review from uncenter January 18, 2025 07:50
@uncenter
Copy link
Member

Fwiw using :has() is fine?

styles/anilist/catppuccin.user.less Outdated Show resolved Hide resolved
@uncenter uncenter changed the title fix(anilist): change text-bright, cleanup fix(anilist): change text-bright Jan 18, 2025
@uncenter uncenter removed the waiting on author Note for staff that a re-review is not yet required label Jan 18, 2025
@AnubisNekhet AnubisNekhet requested a review from uncenter January 20, 2025 23:55
@uncenter uncenter merged commit e0fdf41 into main Jan 21, 2025
2 checks passed
@uncenter uncenter deleted the fix/anilist branch January 21, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
anilist AniList, AniChart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants