Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search functionality #32

Closed
sgoudham opened this issue Mar 24, 2024 · 3 comments · Fixed by #73
Closed

Add search functionality #32

sgoudham opened this issue Mar 24, 2024 · 3 comments · Fixed by #73
Labels
enhancement New feature or request

Comments

@sgoudham
Copy link
Contributor

sgoudham commented Mar 24, 2024

For the search functionality, I'd like to utilise fuse.js as it just works ™️ without any complex setup or hassle.

@sgoudham sgoudham added the enhancement New feature or request label Mar 24, 2024
@sgoudham sgoudham changed the title feat: add search & filter functionality add search & filter functionality Mar 24, 2024
@sgoudham sgoudham changed the title add search & filter functionality Add search & filter functionality Mar 25, 2024
@Tenrys
Copy link

Tenrys commented Apr 17, 2024

I'd happily work on adding this soon!

@sgoudham
Copy link
Contributor Author

I'd happily work on adding this soon!

Thanks for your interest!

We've had some further discussion in our discord regarding this. It looks like we'll need a slight refactor as Astro components aren't dynamic enough here.

We're leaning towards Svelte components and to use the https://github.com/unplugin/unplugin-icons library to retrieve our simple icons along with our custom ones.

@andreasgrafen will have more of an idea on how to approach this and potential blockers!

@unseen-ninja
Copy link
Member

Oh shoot.. I've pushed the whole icon thing waay far back into some dark corner of my brain since it's somewhat of a pain. I should get around to implementing that.

But yeah, the plan is to move the whole ports stuff into a Svelte component in order to implement the dynamic behaviour. This clashes with the current implementation for the Icons though Astro-Icon since these Astro components can only be used within Astro not Svelte.

But I'm also open for suggestions on how to solve this in another way. Do you potentially have something on your mind already @Tenrys?

@sgoudham sgoudham changed the title Add search & filter functionality Add search functionality Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants