-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ports): add search functionality #73
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
uncenter
reviewed
Jun 17, 2024
There's some pretty big layout shifts on the initial page load but searching works as intended. |
Layout shift has been fixed, basically ready to ship. Somewhat concerned about the performance on mobile but I don't think it's too big a problem right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally getting the ball rolling on implementing the much needed search bar 🎉
I'm a bit unhappy with how much the bundle size increases as we need to render the icons on the client, I feel there must be better approaches so I'd appreciate if anyone had any thoughts on a solid approach to import simple-icons, ph-icons and custom icons that we've created ourselves.
TODO:
Suspense behaviour while the icons / components load on the client. (help wanted!)(no longer a big concern, improvements are still welcome)Smooth transitions to make search experience feel good.(not planned anymore)Separate filters for categories.(separate PR)More than happy to accept PRs that are aligned with the TODO items above!
Closes #32