Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ports): add search functionality #73

Merged
merged 19 commits into from
Jun 17, 2024
Merged

feat(ports): add search functionality #73

merged 19 commits into from
Jun 17, 2024

Conversation

sgoudham
Copy link
Contributor

@sgoudham sgoudham commented Jun 16, 2024

Finally getting the ball rolling on implementing the much needed search bar 🎉

I'm a bit unhappy with how much the bundle size increases as we need to render the icons on the client, I feel there must be better approaches so I'd appreciate if anyone had any thoughts on a solid approach to import simple-icons, ph-icons and custom icons that we've created ourselves.

TODO:

  • Suspense behaviour while the icons / components load on the client. (help wanted!) (no longer a big concern, improvements are still welcome)
  • Refactor/tidy up of importing icons. Currently using both svelte icons and astro icon, can we deduplicate it or is it actually less performant if we decide to drop astro icons for all the static pages?
  • Smooth transitions to make search experience feel good. (not planned anymore)
  • Separate filters for categories. (separate PR)
  • Sync search bar with URL query params
  • CSS for everything
  • Set the viewheight on the ports page so that few results doesn't result in the footer being brought up.

More than happy to accept PRs that are aligned with the TODO items above!


Closes #32

Copy link

vercel bot commented Jun 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 0:39am

@sgoudham sgoudham marked this pull request as draft June 16, 2024 01:54
@sgoudham sgoudham changed the title feat: search bar and filters feat: search bar Jun 17, 2024
@sgoudham sgoudham marked this pull request as ready for review June 17, 2024 02:49
@sgoudham
Copy link
Contributor Author

There's some pretty big layout shifts on the initial page load but searching works as intended.

@sgoudham
Copy link
Contributor Author

Layout shift has been fixed, basically ready to ship.

Somewhat concerned about the performance on mobile but I don't think it's too big a problem right now.

@sgoudham sgoudham changed the title feat: search bar feat(ports): add search functionality Jun 17, 2024
@sgoudham sgoudham merged commit 9e2d1ca into main Jun 17, 2024
2 checks passed
@sgoudham sgoudham deleted the feat/search branch June 17, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add search functionality
2 participants