Skip to content
This repository has been archived by the owner on Jul 8, 2024. It is now read-only.

Fix: DOS-237 - Added props.onchange to the callback dependency of numeric inputs and added onKeyDown property so we can bind to it #58

Merged
merged 5 commits into from
Dec 21, 2023
Merged

Fix: DOS-237 - Added props.onchange to the callback dependency of numeric inputs and added onKeyDown property so we can bind to it #58

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bf9e00c
Added props.onchange to the callback dependency as the onChange does …
jsumiguin-causalens Dec 18, 2023
e1f2955
Merge branch 'master' of https://github.com/causalens/dara-ui into DO…
jsumiguin-causalens Dec 18, 2023
ac14940
added tests and changelog
jsumiguin-causalens Dec 19, 2023
46333e1
fixed changelog
jsumiguin-causalens Dec 19, 2023
be6e557
removed if needed
jsumiguin-causalens Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ui-components/src/numeric-input/numeric-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ const NumericInput = React.forwardRef<HTMLInputElement, NumericInputProps>(
props.onChange?.(parsed, e);
},
// eslint-disable-next-line react-hooks/exhaustive-deps
jsumiguin-causalens marked this conversation as resolved.
Show resolved Hide resolved
[props.integerOnly, props.value]
[props.integerOnly, props.value, props.onChange]
);

useEffect(() => {
Expand Down
Loading