Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: DO-3869 input component bug #370

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

patricia-causalens
Copy link
Contributor

Motivation and Context

User found that if they type 10. and then tried to backspace, then it didn't go to 10

Implementation Description

The issue was found that when we updated the input to 10., we keep the value at 10, so when the backspace is pressed the value does go to 10, but since the value hadn't changed then the useEffect was not triggered and so the input was not updated.

Any new dependencies Introduced

None

How Has This Been Tested?

Locally on storybook and by adding a test

PR Checklist:

  • I have implemented all requirements? (see JIRA, project documentation).
  • I am not affecting someone else's work, If I am, they are included as a reviewer.
  • I have added relevant tests (unit, integration or regression).
  • I have added comments to all the bits that are hard to follow.
  • I have added/updated Documentation.
  • I have updated the appropriate changelog with a line for my changes.

Screenshots (if appropriate):

Copy link
Collaborator

@krzysztof-causalens krzysztof-causalens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch :)

@patricia-causalens patricia-causalens merged commit 52c3d46 into master Sep 30, 2024
4 checks passed
@patricia-causalens patricia-causalens deleted the DO-3869-input-component-bug branch September 30, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants