Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: DO-3914 replace deprecated shortid with nanoid #372

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

krzysztof-causalens
Copy link
Collaborator

@krzysztof-causalens krzysztof-causalens commented Oct 2, 2024

Motivation and Context

shortid has been deprecated for a while. We've been slowly migrating to nanoid, this PR removes remaining references to shortid and moves all of them over to nanoid.

Implementation Description

Any new dependencies Introduced

How Has This Been Tested?

Tests passing

PR Checklist:

  • I have implemented all requirements? (see JIRA, project documentation).
  • I am not affecting someone else's work, If I am, they are included as a reviewer.
  • I have added relevant tests (unit, integration or regression).
  • I have added comments to all the bits that are hard to follow.
  • I have added/updated Documentation.
  • I have updated the appropriate changelog with a line for my changes.

Screenshots (if appropriate):

@krzysztof-causalens krzysztof-causalens self-assigned this Oct 2, 2024
@krzysztof-causalens krzysztof-causalens changed the title Deps: replace deprecated shortid with nanoid Deps: DO-3914 replace deprecated shortid with nanoid Oct 2, 2024
@krzysztof-causalens krzysztof-causalens changed the title Deps: DO-3914 replace deprecated shortid with nanoid Improvement: DO-3914 replace deprecated shortid with nanoid Oct 2, 2024
@krzysztof-causalens krzysztof-causalens marked this pull request as ready for review October 2, 2024 17:06
@krzysztof-causalens krzysztof-causalens requested a review from a team October 2, 2024 17:06
Copy link
Contributor

@patricia-causalens patricia-causalens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

@krzysztof-causalens krzysztof-causalens merged commit 168ac5a into master Oct 3, 2024
5 checks passed
@krzysztof-causalens krzysztof-causalens deleted the deps/shortid-nanoid branch October 3, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants