Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: DO-3034 make request() utility options argument optional, defaulting to empty object like fetch #380

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

krzysztof-causalens
Copy link
Collaborator

@krzysztof-causalens krzysztof-causalens commented Oct 25, 2024

Motivation and Context

Noticed while updating internal project, the utility is often called with empty object as second argument.

This PR makes the utility instead accept an arbitrary number of options objects which will be merged in order. This makes the argument optional.

Implementation Description

Any new dependencies Introduced

How Has This Been Tested?

PR Checklist:

  • I have implemented all requirements? (see JIRA, project documentation).
  • I am not affecting someone else's work, If I am, they are included as a reviewer.
  • I have added relevant tests (unit, integration or regression).
  • I have added comments to all the bits that are hard to follow.
  • I have added/updated Documentation.
  • I have updated the appropriate changelog with a line for my changes.

Screenshots (if appropriate):

@krzysztof-causalens krzysztof-causalens self-assigned this Oct 25, 2024
@krzysztof-causalens krzysztof-causalens changed the title Fix: make request() utility options argument optional, defaulting to empty object like fetch Improvement: DO-3034 make request() utility options argument optional, defaulting to empty object like fetch Oct 25, 2024
@krzysztof-causalens krzysztof-causalens requested a review from a team October 25, 2024 14:07
@krzysztof-causalens krzysztof-causalens merged commit ae47d36 into master Oct 25, 2024
3 checks passed
@krzysztof-causalens krzysztof-causalens deleted the fix/request-util-optional branch October 25, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants