Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dara theme docs #384

Merged

Conversation

PatriciaJacob
Copy link
Contributor

Motivation and Context

Docs didn't have an easy visual representation of the theme colors available

Implementation Description

Updated the docs and added two images with the current pre-built themes, also updated the plotting theme section because it is not only Bokeh that can have one set.

Any new dependencies Introduced

None

How Has This Been Tested?

Tested that the code snippets were reasonable on a test app

PR Checklist:

  • I have implemented all requirements? (see JIRA, project documentation).
  • I am not affecting someone else's work, If I am, they are included as a reviewer.
  • I have added relevant tests (unit, integration or regression).
  • I have added comments to all the bits that are hard to follow.
  • I have added/updated Documentation.
  • I have updated the appropriate changelog with a line for my changes.

Screenshots (if appropriate):

Copy link
Collaborator

@krzysztof-causalens krzysztof-causalens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the first time contribution 😉

@krzysztof-causalens krzysztof-causalens merged commit 7b742ce into causalens:master Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants