Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add HKSample Start and End to OCKOutcomeValues #11

Merged
merged 15 commits into from
Aug 6, 2024

Conversation

Rodrigox30
Copy link
Collaborator

No description provided.

@cbaker6 cbaker6 changed the title feat: date acesses for created date to end date to task outcomes feat: Add HKSample Start and End to OCKOutcomeValues Jul 28, 2024
@cbaker6 cbaker6 self-requested a review July 28, 2024 02:10
Copy link
Owner

@cbaker6 cbaker6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, some nits

@Rodrigox30 Rodrigox30 requested a review from cbaker6 August 5, 2024 23:32
Copy link
Owner

@cbaker6 cbaker6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me!

Copy link
Owner

@cbaker6 cbaker6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test are not passing and changes are missing

Copy link
Owner

@cbaker6 cbaker6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for tests to pass

@cbaker6 cbaker6 merged commit 482e0b3 into cbaker6:macOS Aug 6, 2024
11 of 16 checks passed
Rodrigox30 added a commit to Rodrigox30/CareKit that referenced this pull request Aug 6, 2024
* feat: date acesses for created date to end date to task outcomes

* endDate documentation update

* Updated OCKOutcomeValue startDate and endDate documentation to HealthKit documentation.

* Added 2.0 to 3.0 CoreData mapping and adjusted OCKOutcomeValue members

* nits

* Test added for Outcome Value

* CareKitStore3.0 mapping update

* Succesful migration from CareKitStore 2.1 to CareKitStore 3.0.

* Add file to Package.swift

* add files to Xcode project

* fix coredata in project

* nits

* fix absolute path for coredata

* deleted files

---------

Co-authored-by: Corey Baker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants