Defining the logging_in callback when the controller loads #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h the helper_methods) This will ensure that the callback gets defined. Before, define_callbacks was being run before define_concern_callbacks, and so the callback was never defined.
|
just found this & realized the pull request wasn't merged & was just closed - this code definitely fixes my problems, so curious if there is a reason it didn't get merged |
|
@FocusedWanderer to be honest, I had this opened for almost 2 years and hadn't gotten a response, so I closed it 2 years ago when I was cleaning up my repos / open PR list. Feel free to open your own PR with these code changes and try your luck 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I've been able to tell, the include block (where the callbacks were being defined) was always being run before define_concern_callbacks, and so DeviseGuests::Controllers::Helpers.callbacks was always nil and no callbacks were being defined.
Defining the callback when the controller loads seems to fix all of the issues I've been having with the callbacks not being defined.
Do we need to define_callbacks whenever the module is included, or will it be OK to just define them on_load ?