-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature gmt sphere model #265
Merged
cburstedde
merged 19 commits into
cburstedde:feature-gmt
from
ljcarlin:feature-gmt-sphere-model
Feb 19, 2024
Merged
Feature gmt sphere model #265
cburstedde
merged 19 commits into
cburstedde:feature-gmt
from
ljcarlin:feature-gmt-sphere-model
Feb 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljcarlin
force-pushed
the
feature-gmt-sphere-model
branch
from
February 4, 2024 12:58
5e4de15
to
4cc342b
Compare
@cburstedde The diff not updating correctly is apparently a known issue with Github: https://github.com/orgs/community/discussions/16351 I rebased to the most recent version of the preprocessing branch, and that appears to have fixed things. |
The fseek return value had not been checked. This has been added. At the same time, add a call to sc_init to fix parallel logging. Some whitespace, too.
cburstedde
force-pushed
the
feature-gmt-sphere-model
branch
from
February 15, 2024 13:42
6909f06
to
2ae2d94
Compare
Thanks! Merging and going from there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second half of #263
This PR includes consists of the model itself.
The sphere model refines a spherical mesh based on which quadrants intersect specified geodesics. An example application is refining a map of the world based on coastlines.