seperat link command for Winsock #333
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks again! I understand it's not originating from your code, but I'm wondering about an asymmetry with libsc: There we check for WIN32, here for HAVE_WINSOCK2_H. I would imagine this can be unified, with the goal to reduce the diff between the cmake environments of the two libraries as much as we possibly can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title Use seperate link command for WINSOCK_LIBRARY
Following up on issue cburstedde/libsc#206
Proposed changes: Use a seperate command instead of a generator expression. It prevents linker-errors with p4est if these expression fails to be properly generated.