Switch to using two pages #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using npm with these dependencies leads to peer conflicts.
Transition to blue-ish slightly earlier
The established `content` method would already merely append nodes to the current element: it now *replaces* the children and overwrites the entire content, leaving the stage for `append` to provide some value of its own.
So that TypeScript lets me use constructs such as:
[...document.querySelectorAll(...)]
The currently used image is a placeholder. I intend to generate my own SVG made of nice patterns programmatically. Alternatively, an image free of use and contribution (such as those from unsplash.com) may be used, but it'd be better saved in this repository. About that, I should also switch to embedding local copies of the fonts I currently obtain from fonts.google.com.
There's less room for them now, and they were somewhat unhelpful, as well as being rounded, which didn't quite adhere to the geometric theme I adopted. To make up for their removal, I slightly bumped up the vertical gaps in each experience article, as well as the equivalent ones in the highlights on the second page.
This may have been over-the-top.
Try to stick to ~80-ish columns, document CLI options, document hyphenation check in CI/CD, favour yarn over npm.
Using String#split with a regular expression that contains a capture group will include the captured bit as its own element in the resulting array. See https://262.ecma-international.org/5.1/#sec-15.5.4.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"lead"instead of"led")yarn(usingnpmwith these dependencies leads to peer conflicts)s?cssrule in Webpack config (would targetscss?instead ofs?cssscssimport inmain.scss(oddly enough, that wasn't problematic)package.json(have the email come last)