Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix preview size on mobile #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix preview size on mobile #28

wants to merge 1 commit into from

Conversation

cconard96
Copy link
Owner

No description provided.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

@@ -44,8 +44,8 @@ class CameraInput {

initViewport() {
$(`<div id="camera-input-viewport" class="modal" role="dialog">
<div class="modal-dialog" role="dialog">
<div class="modal-body"><video autoplay muted preload="auto"></video></div>
<div class="modal-dialog d-flex justify-content-center" role="dialog">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant