Add connection management permissions

cdapio · Dec 1, 2023 · 3063f27 · 3063f27
1 parent 10334a2
commit 3063f27
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/...rc/main/java/io/cdap/cdap/security/authorization/ldap/role/permission/RolePermission.java b/...rc/main/java/io/cdap/cdap/security/authorization/ldap/role/permission/RolePermission.java
@@ -118,4 +118,7 @@ public enum RolePermission {
   // Source Control Management
   @JsonProperty("Manage Source Control")
   MANAGE_SCM,
+
+  @JsonProperty("Manage Connections")
+  MANAGE_SYSTEM_APP_ENTITIES
 }
diff --git a/...ava/io/cdap/cdap/security/authorization/ldap/role/permission/RolePermissionConverter.java b/...ava/io/cdap/cdap/security/authorization/ldap/role/permission/RolePermissionConverter.java
@@ -102,7 +102,9 @@ public static List<EntityTypeWithPermission> convertToEntityTypeWithPermission(R
           new EntityTypeWithPermission(EntityType.APPLICATION, StandardPermission.CREATE),
           new EntityTypeWithPermission(EntityType.DATASET, StandardPermission.CREATE),
           new EntityTypeWithPermission(EntityType.APPLICATION, StandardPermission.GET),
-          new EntityTypeWithPermission(EntityType.ARTIFACT, StandardPermission.GET)
+          new EntityTypeWithPermission(EntityType.ARTIFACT, StandardPermission.GET),
+          new EntityTypeWithPermission(EntityType.SYSTEM_APP_ENTITY, StandardPermission.CREATE),
+          new EntityTypeWithPermission(EntityType.SYSTEM_APP_ENTITY, StandardPermission.USE)
         );
       case DELETE_PIPELINE:
         return Arrays.asList(
@@ -157,7 +159,8 @@ public static List<EntityTypeWithPermission> convertToEntityTypeWithPermission(R
       case USE_WRANGLER:
         return Arrays.asList(
           new EntityTypeWithPermission(EntityType.APPLICATION, StandardPermission.GET, true),
-          new EntityTypeWithPermission(EntityType.DATASET, StandardPermission.LIST, true)
+          new EntityTypeWithPermission(EntityType.DATASET, StandardPermission.LIST, true),
+          new EntityTypeWithPermission(EntityType.SYSTEM_APP_ENTITY, StandardPermission.USE)
         );
       case MANAGE_SECURE_KEY:
         return Arrays.asList(
@@ -172,6 +175,12 @@ public static List<EntityTypeWithPermission> convertToEntityTypeWithPermission(R
           new EntityTypeWithPermission(EntityType.NAMESPACE, NamespacePermission.WRITE_REPOSITORY),
           new EntityTypeWithPermission(EntityType.NAMESPACE, NamespacePermission.UPDATE_REPOSITORY_METADATA)
         );
+      case MANAGE_SYSTEM_APP_ENTITIES:
+        return Arrays.asList(
+          new EntityTypeWithPermission(EntityType.SYSTEM_APP_ENTITY, StandardPermission.CREATE),
+          new EntityTypeWithPermission(EntityType.SYSTEM_APP_ENTITY, StandardPermission.UPDATE),
+          new EntityTypeWithPermission(EntityType.SYSTEM_APP_ENTITY, StandardPermission.DELETE)
+        );
     }
 
     Permission cdapPermission = getPermission(permission);