Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDAP-21062] Propagate internal credentials in Router #15691

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

adrikagupta
Copy link
Contributor

@adrikagupta adrikagupta commented Aug 28, 2024

Currently, we can only propagate external credentials through the Router. To fix a vulnerability, we need to add the capability of internal credential propagation in router.
Added a unit test for the same.

@adrikagupta adrikagupta added the build Triggers github actions build label Aug 28, 2024
@adrikagupta adrikagupta force-pushed the internal-router-cdf branch 3 times, most recently from 1a4a2c2 to 41e8104 Compare August 28, 2024 09:34
Copy link
Contributor

@dli357 dli357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please address puppycrawl warnings on the PR prior to merging, thank you!

@adrikagupta adrikagupta merged commit fd59e3b into develop Aug 29, 2024
10 of 13 checks passed
@adrikagupta adrikagupta deleted the internal-router-cdf branch August 29, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Triggers github actions build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants