[CDAP-21119] Add metrics for error classification #15815
+170
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsankit-google
force-pushed
the
CDAP-21119
branch
from
60b9b18 to
19672c1
Compare
itsankit-google
force-pushed
the
CDAP-21119
branch
from
19672c1 to
8a28a4c
Compare
tivv
reviewed
Jan 22, 2025
cdap-watchdog/src/main/java/io/cdap/cdap/logging/ErrorLogsClassifier.java
Outdated
Show resolved
Hide resolved
cdap-watchdog/src/main/java/io/cdap/cdap/logging/ErrorLogsClassifier.java
Outdated
Show resolved
Hide resolved
| Metrics.Tag.ERROR_CODE_TYPE, response.getErrorCodeType(), | ||
| Metrics.Tag.ERROR_CODE, response.getErrorCode() | ||
| )); | ||
| context.increment(Metrics.Program.FAILED_RUNS_CLASSIFICATION_COUNT, 1); |
There was a problem hiding this comment.
Should you use gauge? cache is in memory and pod restart / cache overflow would mean doublecounting. And gauge should work the way you want (with all the context) unless I miss something.
There was a problem hiding this comment.
Updated the metric to gauge but I have still kept the cache so that we don't have to do re-processing of logs until cache is overflowed/ pod restart.
itsankit-google
force-pushed
the
CDAP-21119
branch
from
8a28a4c to
36eb1b3
Compare
itsankit-google
force-pushed
the
CDAP-21119
branch
from
36eb1b3 to
2b90997
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira : CDAP-21119
Description
This PR adds support for metrics for error classification for program run.
Added Unit Tests
Tested in CDAP Sandbox