Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDAP-21128] Add rule based error classification #15846

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Conversation

itsankit-google
Copy link
Member

@itsankit-google itsankit-google commented Feb 3, 2025

Jira : CDAP-21128

Description

This PR adds support for rule based error classification for program run failures.

Unit Tests

Added ErrorLogsClassifierTest#testClassifyLogsWithRuleBasedClassification

Tested in CDAP Sandbox

@itsankit-google itsankit-google force-pushed the CDAP-21128 branch 3 times, most recently from 78bffde to 6f31f86 Compare February 5, 2025 13:03
@itsankit-google itsankit-google marked this pull request as ready for review February 5, 2025 13:04
@itsankit-google itsankit-google force-pushed the CDAP-21128 branch 7 times, most recently from 041a1f5 to b996e92 Compare February 5, 2025 15:51
@itsankit-google itsankit-google requested a review from tivv February 5, 2025 16:42
@itsankit-google
Copy link
Member Author

I would still allow it to be specified and not OTHER. Or check MDC tags if we can figure something out automatically. Making it always OTHER limits value of the rules

rule-based classification is only meant to be used when we are not able to identify things using failureDetailsProvider but it still helps to identify the major probable error which caused the program run to fail.

@itsankit-google itsankit-google added the build Triggers github actions build label Feb 5, 2025
@itsankit-google itsankit-google force-pushed the CDAP-21128 branch 9 times, most recently from 6135feb to 0f5ef26 Compare February 7, 2025 05:10
Copy link

sonarqubecloud bot commented Feb 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
72.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@itsankit-google itsankit-google merged commit 6d73fb8 into develop Feb 7, 2025
11 of 12 checks passed
@itsankit-google itsankit-google deleted the CDAP-21128 branch February 7, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Triggers github actions build error-management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants