Consolidate Metrics Query and Metrics Proccessor Services #15870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhardwaj-priyanshu
force-pushed
the
feature/combine-metric-ip
branch
7 times, most recently
from
2acedb5 to
d49ec7f
Compare
bhardwaj-priyanshu
force-pushed
the
feature/combine-metric-ip
branch
from
d49ec7f to
04db1f1
Compare
vsethi09
reviewed
Feb 13, 2025
| @@ -53,7 +53,7 @@ private enum AllowedMethod { | |||
| Constants.Service.LOG_QUERY); | |||
| public static final RouteDestination LOG_SAVER = new RouteDestination(Constants.Service.LOGSAVER); | |||
| public static final RouteDestination METRICS_PROCESSOR = new RouteDestination( | |||
| Constants.Service.METRICS_PROCESSOR); | |||
| Constants.Service.METRICS); | |||
There was a problem hiding this comment.
Replace METRICS_PROCESSOR with METRICS in the below code.
vsethi09
reviewed
Feb 13, 2025
| @@ -525,7 +525,6 @@ private static List<Module> createPersistentModules(CConfiguration cConf, Config | |||
| cConf.set(Constants.Transaction.Container.ADDRESS, localhost); | |||
| cConf.set(Constants.Dataset.Executor.ADDRESS, localhost); | |||
| cConf.set(Constants.Metrics.ADDRESS, localhost); | |||
| cConf.set(Constants.MetricsProcessor.BIND_ADDRESS, localhost); | |||
There was a problem hiding this comment.
Should we bind Metrics service address here?
There was a problem hiding this comment.
its already binded
bhardwaj-priyanshu
force-pushed
the
feature/combine-metric-ip
branch
2 times, most recently
from
7ba682d to
e5e4bdc
Compare
bhardwaj-priyanshu
force-pushed
the
feature/combine-metric-ip
branch
from
e5e4bdc to
cd4bef4
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics Query and Metrics Proccessor runs on the same pod, but consumes 2 cluster IP. This PR consolidates both the services into Metrics saving one cluster IP.
Testing