refactor(parse): explicit undefined instead of empty string (#115)

cdcabrera · Jan 29, 2024 · e4365d7 · e4365d7
1 parent aab6323
commit e4365d7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/__tests__/__snapshots__/parse.test.js.snap b/src/__tests__/__snapshots__/parse.test.js.snap
@@ -263,7 +263,7 @@ exports[`Parse should parse a commit message: parseCommitMessages 1`] = `
     "description": "issues/20 sit enhancements",
     "hash": "1f72345b597123453031234555b6d25574ccacee",
     "isBreaking": false,
-    "prNumber": "",
+    "prNumber": undefined,
     "scope": "dolor",
     "type": "feat",
     "typeScope": "feat(dolor)",
@@ -272,7 +272,7 @@ exports[`Parse should parse a commit message: parseCommitMessages 1`] = `
     "description": "missing semicolon",
     "hash": "1f12p45b597123453031234555b6dl2401ccacee",
     "isBreaking": false,
-    "prNumber": "",
+    "prNumber": undefined,
     "scope": undefined,
     "type": "fix",
     "typeScope": "fix",

diff --git a/src/parse.js b/src/parse.js
@@ -63,16 +63,16 @@ const parseCommitMessage = (
 
   const [hashTypeScope, ...descriptionEtAll] = message.trim().split(/:/);
   const [description, ...partialPr] = descriptionEtAll.join(' ').trim().split(/\(#/);
-  const [hash, typeScope = ''] = hashTypeScope.replace(/!$/, '').trim().split(/\s/);
-  const [type, scope = ''] = typeScope.split('(');
+  const [hash, ...typeScope] = hashTypeScope.replace(/!$/, '').trim().split(/\s/);
+  const [type, scope = ''] = typeScope.join(' ').trim().split('(');
 
   output = {
     hash,
-    typeScope,
-    type: commitType?.[type]?.value,
+    typeScope: typeScope.join(' ').trim() || undefined,
+    type: commitType?.[type]?.value || undefined,
     scope: scope.split(')')[0] || undefined,
-    description: description.trim(),
-    prNumber: (partialPr.join('(#').trim() || '').replace(/\D/g, ''),
+    description: description.trim() || undefined,
+    prNumber: (partialPr.join('(#').trim() || '').replace(/\D/g, '') || undefined,
     isBreaking
   };