Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): global options #23

Merged
merged 1 commit into from
Dec 23, 2022
Merged

refactor(cli): global options #23

merged 1 commit into from
Dec 23, 2022

Conversation

cdcabrera
Copy link
Owner

What's included

  • refactor(cli): global options

Notes

  • restructures passing options via a central/global'ish var instead of drilling
    • should make it easier with updates

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean and the same snapshot outputs

Example

...

Updates issue/story

ongoing

@cdcabrera cdcabrera added the refactor no quite performance, not quite broken, just different label Dec 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2022

Codecov Report

Merging #23 (49a0a44) into main (64b13ab) will increase coverage by 0.54%.
The diff coverage is 96.42%.

❗ Current head 49a0a44 differs from pull request most recent head 20b35d7. Consider uploading reports for the commit 20b35d7 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   91.22%   91.77%   +0.54%     
==========================================
  Files           5        5              
  Lines         228      231       +3     
  Branches       88       92       +4     
==========================================
+ Hits          208      212       +4     
+ Misses         19       18       -1     
  Partials        1        1              
Impacted Files Coverage Δ
src/global.js 85.00% <85.71%> (+3.75%) ⬆️
src/index.js 86.66% <94.73%> (+4.05%) ⬆️
src/cmds.js 92.30% <100.00%> (-0.15%) ⬇️
src/files.js 89.58% <100.00%> (+2.08%) ⬆️
src/parse.js 96.29% <100.00%> (-0.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64b13ab...20b35d7. Read the comment docs.

src/__tests__/global.test.js Show resolved Hide resolved
src/files.js Show resolved Hide resolved
src/parse.js Outdated Show resolved Hide resolved
* testing, lint, mock objects
* cli, set options
* cmds, files, parse, global options
* index, global options, settings
@cdcabrera cdcabrera marked this pull request as ready for review December 23, 2022 16:13
@cdcabrera cdcabrera merged commit b9d6aeb into main Dec 23, 2022
@cdcabrera cdcabrera deleted the dev-options branch December 23, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor no quite performance, not quite broken, just different
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants