Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add golden tests (#75) #82

Merged
merged 1 commit into from
Oct 20, 2024
Merged

chore: add golden tests (#75) #82

merged 1 commit into from
Oct 20, 2024

Conversation

blackheaven
Copy link
Contributor

No description provided.

@Vlix
Copy link
Collaborator

Vlix commented Oct 15, 2024

Thanks so much for the PR! 🙏

I'll try to look at this (and fix the CI) in the coming month.

@Vlix
Copy link
Collaborator

Vlix commented Oct 19, 2024

@blackheaven
If you could rebase this on master, that'd fix the CI again :)

@blackheaven
Copy link
Contributor Author

Done, thanks.

Vlix
Vlix requested changes Oct 19, 2024
View reviewed changes
Copy link
Collaborator

@Vlix Vlix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a few things that look irregular

password/test/golden/Bcrypt_cost4.golden Show resolved Hide resolved
password/test/golden/Scrypt_outputLength16.golden Show resolved Hide resolved
@Vlix Vlix merged commit 573dfc8 into cdepillabout:master Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vlix Vlix Vlix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blackheaven @Vlix