Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The artifact subject.change field is not documented explicitly #115

Closed
e-backmark-ericsson opened this issue Feb 17, 2023 · 1 comment · Fixed by #117
Closed

The artifact subject.change field is not documented explicitly #115

e-backmark-ericsson opened this issue Feb 17, 2023 · 1 comment · Fixed by #117
Assignees
@afrittoli
Labels
bug Something isn't working
Milestone
v0.2

Comments

@e-backmark-ericsson
Copy link
Contributor

The subject artifact has the field change according to this table: https://github.com/cdevents/spec/blob/main/continuous-integration-pipeline-events.md#artifact, but it is not described as a valid field for any of its event descriptions: https://github.com/cdevents/spec/blob/main/continuous-integration-pipeline-events.md#artifact-packaged
It is a required field according to the artifact.packaged schema: https://github.com/cdevents/spec/blob/main/schemas/artifactpackaged.json#L56
@e-backmark-ericsson e-backmark-ericsson added the bug Something isn't working label Feb 17, 2023
@e-backmark-ericsson e-backmark-ericsson added this to the v0.2 milestone Feb 17, 2023
@afrittoli
Copy link
Contributor

Thanks @e-backmark-ericsson - it should indeed be documented in the artifact packaged table, I will fix that

@afrittoli afrittoli self-assigned this Mar 9, 2023
afrittoli added a commit to afrittoli/cdevents-spec that referenced this issue Mar 9, 2023
@afrittoli
Add the change field to the artifact packaged
b7cf5c6 
The field is already documented for the subject and included in the
jsonschema, but when I added it a missed to update the artifact
packaged field table in the markdown spec.

Fixes: cdevents#115

Signed-off-by: Andrea Frittoli <[email protected]>
@afrittoli afrittoli mentioned this issue Mar 9, 2023
Merged
4 tasks
@afrittoli afrittoli moved this from Todo to In Progress in CDEvents Releases Mar 9, 2023
afrittoli added a commit that referenced this issue Mar 10, 2023
@afrittoli
Add the change field to the artifact packaged
014b28d 
The field is already documented for the subject and included in the
jsonschema, but when I added it a missed to update the artifact
packaged field table in the markdown spec.

Fixes: #115

Signed-off-by: Andrea Frittoli <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in CDEvents Releases Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afrittoli afrittoli

Labels
bug Something isn't working
Projects
CDEvents Releases
Status: Done
Milestone
v0.2
Development

Successfully merging a pull request may close this issue.

Add the change field to the artifact packaged afrittoli/cdevents-spec
2 participants
@afrittoli @e-backmark-ericsson