Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links are missing in the custom schema #216

Closed
afrittoli opened this issue May 10, 2024 · 0 comments · Fixed by #227
Closed

Links are missing in the custom schema #216

afrittoli opened this issue May 10, 2024 · 0 comments · Fixed by #227
Milestone

Comments

@afrittoli
Copy link
Contributor

The schema for custom events does not include the chain_id and links part in the context.

@afrittoli afrittoli added this to the v0.4 milestone May 10, 2024
afrittoli added a commit to afrittoli/cdevents-spec that referenced this issue May 15, 2024
The custom schema had a few issues to be fixed:
- missing chainId and links from the context
- missing version in the type regex
- replace "." with "\." in the type regex

This PR fixes all those and adds a conformance.json example
file to validate against the custom schema.

Fixes cdevents#216

Signed-off-by: Andrea Frittoli <[email protected]>
afrittoli added a commit to afrittoli/cdevents-spec that referenced this issue May 15, 2024
The custom schema had a few issues to be fixed:
- missing chainId and links from the context
- missing version in the type regex
- replace "." with "\." in the type regex

This PR fixes all those and adds a conformance.json example
file to validate against the custom schema.

Fixes cdevents#216

Signed-off-by: Andrea Frittoli <[email protected]>
afrittoli added a commit to afrittoli/cdevents-spec that referenced this issue May 15, 2024
The custom schema had a few issues to be fixed:
- missing chainId and links from the context
- missing version in the type regex
- replace "." with "\." in the type regex

This PR fixes all those and adds a conformance.json example
file to validate against the custom schema.

Fixes cdevents#216

Signed-off-by: Andrea Frittoli <[email protected]>
afrittoli added a commit to afrittoli/cdevents-spec that referenced this issue May 15, 2024
The custom schema had a few issues to be fixed:
- missing chainId and links from the context
- missing version in the type regex
- replace "." with "\." in the type regex

This PR fixes all those and adds a conformance.json example
file to validate against the custom schema.

Fixes cdevents#216

Signed-off-by: Andrea Frittoli <[email protected]>
afrittoli added a commit to afrittoli/cdevents-spec that referenced this issue May 15, 2024
The custom schema had a few issues to be fixed:
- missing chainId and links from the context
- missing version in the type regex
- replace "." with "\." in the type regex

This PR fixes all those and adds a conformance.json example
file to validate against the custom schema.

Fixes cdevents#216

Signed-off-by: Andrea Frittoli <[email protected]>
afrittoli added a commit that referenced this issue May 15, 2024
The custom schema had a few issues to be fixed:
- missing chainId and links from the context
- missing version in the type regex
- replace "." with "\." in the type regex

This PR fixes all those and adds a conformance.json example
file to validate against the custom schema.

Fixes #216

Signed-off-by: Andrea Frittoli <[email protected]>
afrittoli added a commit that referenced this issue May 15, 2024
The custom schema had a few issues to be fixed:
- missing chainId and links from the context
- missing version in the type regex
- replace "." with "\." in the type regex

This PR fixes all those and adds a conformance.json example
file to validate against the custom schema.

Fixes #216

Signed-off-by: Andrea Frittoli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant