Introduce links to CDEvents #139

xibz · 2023-05-30T15:10:33Z

Changes

This commits introduces the concept of linking events to CDEvents. We take inspiration from Eiffel for certain components, and also outline new APIs and use cases.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has the primer doc been updated if a design decision is involved
Have the JSON schemas been updated if the specification changed
Has spec version and event versions been updated according to the versioning policy
Meets the CDEvents contributor standards

links.md

e-backmark-ericsson

@xibz, please don't overwrite the old commits when doing new ones. It becomes very time consuming to review the changes when there is nothing to compare the updates towards. We will anyway squash the commits when merging the PR eventually, so there should be no problem having many commits on the PR.

links.md

schemas/links/embeddedlinkrelation.json

schemas/servicerolledback.json

afrittoli

Thanks for all the updates.
It mostly looks great, thank you. I'm still unconvinced by END links though.
There are some follow-up needed too, but not in this PR.

examples/artifact_published.json

links.md

schemas/artifactpublished.json

schemas/links/embeddedlinkrelation.json

.spellcheck.yml

schemas/artifactpackaged.json

schemas/artifactpublished.json

schemas/artifactdeleted.json

afrittoli

Thank you @xibz - excited to see this ready to be merged!

This commits introduces the concept of linking events to CDEvents. We take inspiration from Eiffel for certain components, and also outline new APIs and use cases. Signed-off-by: benjamin-j-powell <[email protected]> Cleanup the custom spellcheck dictionary Signed-off-by: Andrea Frittoli <[email protected]> Fix linting issues Signed-off-by: Andrea Frittoli <[email protected]> Fix references to link schemas Make the references start with a / and include the whole path relative to the main schema base URL. See https://json-schema.org/understanding-json-schema/structuring#dollarref Schemas from the PR may not be published yet, so adapt the CI job to look for local files instead. Signed-off-by: Andrea Frittoli <[email protected]> Fix wrong event versions Artifact packaged and artifact published had the wrong event versions. Return to v0.2.0-draft (which was already bumped in this release. Examples already match. Signed-off-by: Andrea Frittoli <[email protected]> Signed-off-by: xibz <[email protected]>

This comment was marked as resolved.

Sign in to view

xibz force-pushed the links branch 3 times, most recently from fc04bcf to ec74ada Compare June 21, 2023 07:29

afrittoli mentioned this pull request Jun 22, 2023

Connecting Events #104

Closed

xibz force-pushed the links branch from ec74ada to af66863 Compare June 22, 2023 18:56

e-backmark-ericsson reviewed Jun 27, 2023

View reviewed changes

links.md Outdated Show resolved Hide resolved

links.md Outdated Show resolved Hide resolved

links.md Outdated Show resolved Hide resolved

links.md Outdated Show resolved Hide resolved

afrittoli reviewed Jun 27, 2023

View reviewed changes