-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize values and type of outcome #238
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Brett Smith <[email protected]>
See also #215 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afrittoli - I think this change is fine, but you had some comments from #237, but I think this PR still satisfies your concerns. I think this approach is just standardizing on what word to use to signify passing or failing of a test, in this case success
and failure
given that other enums rely on success
and failure
.
This does get rid of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olensmar - Hey Ole, we are interested in enforcing some consistency across events.
So the idea is
- pass -> success
- fail -> failure
While pass
is pretty standard to testing frameworks, I'd be okay keeping it as passed, but if we want to use fail
, we should decide whether we use fail
everywhere or failure
. Since failure
is used more widely, we opted to use failure
. How do you feel about this change?
@xibz sorry for the later reply - change is fine by me! |
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist: