Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sort keys of ApiObject manifests #67

Merged
merged 6 commits into from
Mar 12, 2020

Conversation

campionfellin
Copy link
Contributor

Fixes #17

Using json-stable-stringify to sort output alphabetically and recursively.

Signed-off-by: campionfellin [email protected]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See note about bundled dependency.

packages/cdk8s/package.json Outdated Show resolved Hide resolved
packages/cdk8s/lib/api-object.ts Show resolved Hide resolved
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

@eladb eladb changed the title Sort ApiObject YAML output alphabetically feat: sort keys of ApiObject manifests Mar 12, 2020
@eladb eladb merged commit 1fe89bd into cdk8s-team:master Mar 12, 2020
@campionfellin campionfellin deleted the issue17 branch March 12, 2020 16:29
@tabern
Copy link
Contributor

tabern commented Mar 12, 2020

Nice work - thanks @campionfellin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Suggestion] fix ordering in YAML output
3 participants