chore: notice for https://github.com/aws/aws-cdk/issues/28520 #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaizencc
requested changes
Jan 3, 2024
data/notices.json
Outdated
| "components": [ | ||
| { | ||
| "name": "aws-cdk-lib/aws-event.EventBus", | ||
| "version": "2.117.0" |
There was a problem hiding this comment.
Only version 2.117 affected?
data/notices.json
Outdated
| { | ||
| "title": "(aws-events): EventBus fails because of change to logical id without modifiying the statement id", | ||
| "issueNumber": 28520, | ||
| "overview": "#27340 introduced the ability to create multiple event bus policies on a single event bus. To facilitate this, the logical Id was changed from \"Policy\" to the statementId. This triggers a replacement, which fails in CloudFormation because the statement ID does not change.", |
There was a problem hiding this comment.
#27340 isn't going to mean anything to the people who view this (when they cdk synth their apps). can you rewrite this overview to be self-sufficient
data/notices.json
Outdated
| @@ -423,6 +423,18 @@ | |||
| } | |||
| ], | |||
| "schemaVersion": "1" | |||
| }, | |||
| { | |||
| "title": "(aws-events): EventBus fails because of change to logical id without modifiying the statement id", | |||
There was a problem hiding this comment.
this is what everyone who uses EventBus is going to see. Is it true that all users will see a failure? Because that is what this title is implying to me.
Co-authored-by: Kaizen Conroy <[email protected]>
kaizencc
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice for #28520