Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): migrate to stable synthetics #279

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

nicoalonsop
Copy link
Contributor

Based on aws/aws-cdk#27305 I have updated the dependencies.

I know that the tests are failing. Happy to receive help to fix them.

@nicoalonsop nicoalonsop force-pushed the migrate-to-stable-synthetics branch from 89e9d07 to 773ebd8 Compare September 28, 2023 23:12
@nicoalonsop nicoalonsop changed the title Migrate to stable synthetics fix(deps): migrate to stable synthetics Sep 28, 2023
@nicoalonsop
Copy link
Contributor Author

Hey @cplee, Would you mind looking into this?
Any suggestions or comments?

Thanks in advance!

@cplee
Copy link
Contributor

cplee commented Oct 3, 2023

Rebased and started build.

@cplee
Copy link
Contributor

cplee commented Oct 3, 2023

@nicoalonsop - thanks for these changes. Can you try running yarn integ:snapshot-all to and then yarn test to confirm snapshot update will fix the failing tests?

@cplee
Copy link
Contributor

cplee commented Oct 3, 2023

fixes #235

@cplee cplee merged commit 3c5b6d9 into cdklabs:main Oct 3, 2023
@nicoalonsop nicoalonsop deleted the migrate-to-stable-synthetics branch October 3, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants