-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propose order-sign hook #429
Conversation
Note that this hook is intended to deprecate order-review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor edits
1) fix misspelling of quantity 2) Clarify that hooks is agnostic of the type of order. 3) Clarify that this hooks "replaces" order-review. 4) Rename context `orders` field to `draftOrders`
Hey @brettmarquard - will you re-review and verify that I addressed all your comments (and approve if appropriate)? |
I am recommending that order-select be generalized to optionally include updates as the order details are entered, per @kpshek's proposal in that PR. And that we accept @kpshek's wordsmithed language in this PR, too. Two small tweaks that would preserve important aspects of the current functionality. |
Ok fine @jmandel.
|
also change version from 0.1 to 1.0
Hey Guys, This PR has been updated. Please review. |
non-substantive change to comply with new hook template
Note that this hook is intended to either deprecate or clarify order-review (depending upon the actual workflow intent of order-review).