Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose order-sign hook #429

Merged
merged 7 commits into from
Feb 25, 2019
Merged

Propose order-sign hook #429

merged 7 commits into from
Feb 25, 2019

Conversation

isaacvetter
Copy link
Member

@isaacvetter isaacvetter commented Nov 15, 2018

Note that this hook is intended to either deprecate or clarify order-review (depending upon the actual workflow intent of order-review).

Note that this hook is intended to deprecate order-review.
@kpshek kpshek temporarily deployed to cds-hooks-docs-pr-429 November 15, 2018 21:53 Inactive
@kpshek kpshek temporarily deployed to cds-hooks-docs-pr-429 November 19, 2018 22:42 Inactive
Copy link
Collaborator

@brettmarquard brettmarquard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor edits

1) fix misspelling of quantity 
2) Clarify that hooks is agnostic of the type of order. 
3) Clarify that this hooks "replaces" order-review.
4) Rename context `orders` field to `draftOrders`
@isaacvetter
Copy link
Member Author

Hey @brettmarquard - will you re-review and verify that I addressed all your comments (and approve if appropriate)?

@jmandel
Copy link
Member

jmandel commented Feb 22, 2019

I am recommending that order-select be generalized to optionally include updates as the order details are entered, per @kpshek's proposal in that PR.

And that we accept @kpshek's wordsmithed language in this PR, too.

Two small tweaks that would preserve important aspects of the current functionality.

@mattvarghese
Copy link
Contributor

mattvarghese commented Feb 22, 2019

I am recommending that order-select be generalized to optionally include updates as the order details are entered, per @kpshek's proposal in that PR.

And that we accept @kpshek's wordsmithed language in this PR, too.

Two small tweaks that would preserve important aspects of the current functionality.

Ok fine @jmandel.

  1. I agree with the above in full and unqualified, withdrawing my previous disagreement on order-select
  2. I tried in vain to uphold the decisions of the HL7 CDS Hooks workgroup call on 01/30/19

also change version from 0.1 to 1.0
@isaacvetter isaacvetter requested a review from jmandel February 22, 2019 07:01
@isaacvetter
Copy link
Member Author

Hey Guys, This PR has been updated. Please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants