Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V 1.1.2 #122

Merged
merged 10 commits into from
May 31, 2023
Merged

V 1.1.2 #122

merged 10 commits into from
May 31, 2023

Conversation

melaniebmn
Copy link
Collaborator

@melaniebmn melaniebmn commented May 31, 2023

v1.1.2

Minor

  • Change focus colour from #303fc3 to #0535d2 to be compliant with canada.ca
  • Change primary text colour from #000 to chore: GCDS Tokens Release v1.20.0 #333 to be compliant with canada.ca
  • Change link hover colour from #26374a to #0535d2 to be compliant with canada.ca
  • Change link colour from #425a76 to #2b4380 to be compliant with canada.ca
  • Update the footer contextual background colour with the canada.ca colour
  • Change danger & error border colour from #c24438 to #d3080c to be compliant with canada.ca

Patch

  • Move global tokens for container, spacing, and typography into the global folder
  • Reorganize blue colour tokens from light to dark
  • Ensure the Canada signature uses black text

Notes:

We are updating some of our colour tokens to be better aligned with the Canada.ca mandatory colour palette. As part of this change, the blue colour palette had to be reordered to keep the blue colours properly organized from light to dark. Here is a summary of that change:

  • The old blue.focus colour token has been switched to blue.850. It is now also used for link hovers and the primary button background hover colour and therefore, it wasn't semantically correct to keep it as blue.focus.
  • The new link colour #2b4380 (the old blue.700 colour token) is darker than the blue.800 colour token. The two tokens have been swapped, #2b4380 is now blue.800 and #33465c is now blue.700.

Side-by-side overview of the colour updates and what that changes looks like for our components:

canadaca-colour-update-before-and-after

@melaniebmn melaniebmn requested a review from ethanWallace May 31, 2023 19:32
Copy link
Collaborator

@ethanWallace ethanWallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work!

@melaniebmn melaniebmn merged commit 832e0ba into main May 31, 2023
@melaniebmn melaniebmn deleted the switch-to-mandatory-colours branch May 31, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants