Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nav tokens #131

Merged
merged 13 commits into from
Jul 4, 2023
Merged

Add nav tokens #131

merged 13 commits into from
Jul 4, 2023

Conversation

melaniebmn
Copy link
Collaborator

@melaniebmn melaniebmn commented Jun 28, 2023

Version 1.4.0

Minor

  • Add gcds-nav-link tokens
  • Add gcds-nav-group-tokens
  • Add gcds-side-nav tokens
  • Add gcds-top-nav tokens

Patch

  • Update container sizes xl and lg
  • Remove site-menu tokens

@melaniebmn melaniebmn marked this pull request as draft June 28, 2023 00:03
@melaniebmn melaniebmn marked this pull request as ready for review June 28, 2023 15:38
@melaniebmn melaniebmn requested a review from ethanWallace June 28, 2023 15:38
ethanWallace
ethanWallace previously approved these changes Jun 29, 2023
Copy link
Collaborator

@ethanWallace ethanWallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ethanWallace ethanWallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melaniebmn melaniebmn merged commit 0e3ec4f into main Jul 4, 2023
@melaniebmn melaniebmn deleted the add-nav-tokens branch July 4, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants