Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing issue with single output from node being an array #5

Closed
wants to merge 1 commit into from
Closed

Addressing issue with single output from node being an array #5

wants to merge 1 commit into from

Conversation

anomam
Copy link

@anomam anomam commented Mar 22, 2018

Fix for issue #4

* Also had to make sure unused dimensions were squeezed out
* Adding the numpy dependency may not be ideal here...
@anomam anomam changed the base branch from master to develop March 22, 2018 09:12
@cedricleroy
Copy link
Owner

Thanks for the PR, Marc. It fails the tests because of the use of numpy and this line. I would like to limit the dependencies if not absolutely needed, so I pushed this pure Python alternative. Let me know if it works, I like your use of squeeze as it may be a more global solution that cover cases I am not really seeing right now.

@anomam
Copy link
Author

anomam commented Mar 23, 2018

Ok, I just saw that you created a whole new PR for this.
Because I'm importing functions from another package, I do need to squeeze the returned values for the dag to work. But no need to add a dependency on numpy indeed, I just created a decorating function in my script that wraps the imported functions to squeeze their results.
Also, I think that it may be a little harsh to raise an exception when an input is not used, but I can see arguments for having it also. So no worries.
I'm closing this PR in favor of your solution.
Thanks

@anomam anomam closed this Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants