Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Validate SQS SSL certs by default" #2114

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Revert "Validate SQS SSL certs by default" #2114

merged 1 commit into from
Sep 16, 2024

Conversation

Nusnus
Copy link
Member

@Nusnus Nusnus commented Sep 14, 2024

Reverts #2094 per the conversation in #2113

@Nusnus Nusnus self-assigned this Sep 14, 2024
auvipy
auvipy approved these changes Sep 15, 2024
View reviewed changes
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems we should have proper tests before merging in the original PR

@Nusnus Nusnus marked this pull request as ready for review September 16, 2024 17:14
@Nusnus Nusnus merged commit a626f1f into main Sep 16, 2024
30 checks passed
@Nusnus Nusnus deleted the revert-2094-sqs-default-verify-ssl branch September 16, 2024 17:14
@spawn-guy spawn-guy mentioned this pull request Oct 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

Assignees

@Nusnus Nusnus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nusnus @auvipy