Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/user: Signer automatically estimates gas #3342

Closed
renaynay opened this issue Apr 18, 2024 · 1 comment · Fixed by #3510
Closed

pkg/user: Signer automatically estimates gas #3342

renaynay opened this issue Apr 18, 2024 · 1 comment · Fixed by #3510
Assignees
@vgonkivs
Labels
priority:high optional label to track the relative priority of planned items WS: BestTxs Reliable and seamless transaction flow

Comments

@renaynay
Copy link
Member

celestiaorg/celestia-node#3298 (comment)
@cmwaters cmwaters added priority:normal optional label to track the relative priority of planned items WS: BestTxs Reliable and seamless transaction flow and removed needs:triage labels Apr 18, 2024
@cmwaters cmwaters mentioned this issue Apr 23, 2024
Closed
@cmwaters
Copy link
Contributor

For simple PFBs we should use the modelled formula for estimating gas. For any other transaction we should use the EstimateGas function.

We should have a gas multiplier field which we multiply by when using EstimateGas (as it occasionally underestimates). This should be adjustable with a default of 1.1

@cmwaters cmwaters added priority:high optional label to track the relative priority of planned items and removed external priority:normal optional label to track the relative priority of planned items labels Apr 23, 2024
@vgonkivs vgonkivs assigned vgonkivs and unassigned cmwaters Apr 23, 2024
@coderabbitai coderabbitai bot mentioned this issue Apr 25, 2024
Merged
@vgonkivs vgonkivs mentioned this issue May 29, 2024
Merged
cmwaters pushed a commit that referenced this issue Jun 3, 2024
@vgonkivs
feat: add auto gas and fee estimations (#3510)
af426bf 
Closes #3342
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@vgonkivs
feat: add auto gas and fee estimations (#3510)
522aac8 
Closes celestiaorg/celestia-app#3342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vgonkivs vgonkivs

Labels
priority:high optional label to track the relative priority of planned items WS: BestTxs Reliable and seamless transaction flow
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add auto gas and fee estimations vgonkivs/celestia-app
3 participants
@cmwaters @vgonkivs @renaynay