Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: gas optimization in qgb end blocker #1800

Merged
merged 4 commits into from
May 22, 2023
Merged

feat: gas optimization in qgb end blocker #1800

merged 4 commits into from
May 22, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented May 20, 2023

Overview

closes #1778

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id added the x/qgb label May 20, 2023
@rach-id rach-id requested a review from evan-forbes as a code owner May 20, 2023 20:52
@rach-id rach-id self-assigned this May 20, 2023
@MSevey MSevey requested review from a team and staheri14 and removed request for a team May 20, 2023 20:53
@rach-id rach-id closed this May 21, 2023
@rach-id rach-id reopened this May 21, 2023
@MSevey MSevey requested a review from a team May 21, 2023 09:05
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2023 •
edited
Loading

Codecov Report

Merging #1800 (9d62835) into main (1e60076) will increase coverage by 0.12%.
The diff coverage is 54.60%.

@@            Coverage Diff             @@
##             main    #1800      +/-   ##
==========================================
+ Coverage   51.54%   51.66%   +0.12%     
==========================================
  Files          95      107      +12     
  Lines        6220     6656     +436     
==========================================
+ Hits         3206     3439     +233     
- Misses       2671     2862     +191     
- Partials      343      355      +12
Impacted Files Coverage Δ
app/app.go 4.48% <0.00%> (-0.05%) ⬇️
app/default_overrides.go 24.32% <0.00%> (ø)
app/prepare_proposal.go 0.00% <0.00%> (ø)
app/process_proposal.go 0.00% <0.00%> (ø)
app/square_size.go 0.00% <0.00%> (ø)
pkg/da/data_availability_header.go 71.02% <0.00%> (ø)
pkg/proof/querier.go 21.50% <0.00%> (ø)
test/txsim/client.go 77.43% <0.00%> (-1.45%) ⬇️
x/mint/types/genesis.go 0.00% <0.00%> (ø)
x/mint/keeper/querier.go 2.85% <2.85%> (ø)
... and 19 more

@MSevey MSevey requested a review from a team May 22, 2023 11:38
@MSevey MSevey requested a review from a team May 22, 2023 15:05
@evan-forbes evan-forbes changed the title feat: gaz optimization in qgb end blocker feat: gas optimization in qgb end blocker May 22, 2023
@MSevey MSevey requested a review from a team May 22, 2023 17:28
@rach-id rach-id merged commit 69259f5 into celestiaorg:main May 22, 2023
rach-id added a commit to rach-id/celestia-app that referenced this pull request May 23, 2023
@rach-id
feat: gas optimization in qgb end blocker (celestiaorg#1800)
7075501 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

closes celestiaorg#1778
<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootulp rootulp rootulp approved these changes

@evan-forbes evan-forbes evan-forbes approved these changes

@staheri14 staheri14 Awaiting requested review from staheri14 staheri14 is a code owner automatically assigned from celestiaorg/celestia-core

Assignees

@rach-id rach-id

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize QGB end blocker gas usage
4 participants
@rach-id @codecov-commenter @rootulp @evan-forbes