Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade to cosmos-sdk v1.19.0-sdk-v0.46.16 #2865

Closed
wants to merge 2 commits into from
Closed

chore: upgrade to cosmos-sdk v1.19.0-sdk-v0.46.16 #2865

wants to merge 2 commits into from

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Nov 21, 2023 •
edited
Loading

@rootulp rootulp self-assigned this Nov 21, 2023
@rootulp rootulp mentioned this pull request Nov 21, 2023
Merged
5 tasks
@rootulp
Copy link
Collaborator Author

rootulp commented Nov 21, 2023 •
edited
Loading

Identified the issue by reproing locally

$ go build -tags ledger -o celestia-appd ../../cmd/celestia-appd
# github.com/cosmos/cosmos-sdk/crypto/ledger
/Users/rootulp/go/pkg/mod/github.com/celestiaorg/[email protected]/crypto/ledger/ledger_real.go:18:10: cannot use device (variable of type *ledger_cosmos_go.LedgerCosmos) as SECP256K1 value in return statement: *ledger_cosmos_go.LedgerCosmos does not implement SECP256K1 (wrong type for method SignSECP256K1)
		have SignSECP256K1([]uint32, []byte, byte) ([]byte, error)
		want SignSECP256K1([]uint32, []byte) ([]byte, error)

Even though ledger-cosmos-go was downgraded to v0.12.4 here it wasn't downgraded in this PR after running go mod tidy.

@rootulp rootulp marked this pull request as ready for review November 21, 2023 22:04
rootulp
rootulp commented Nov 21, 2023
View reviewed changes
go.mod
@@ -44,7 +44,7 @@ require (
github.com/bits-and-blooms/bitset v1.7.0 // indirect
github.com/consensys/bavard v0.1.13 // indirect
github.com/consensys/gnark-crypto v0.12.1 // indirect
github.com/cosmos/ledger-cosmos-go v0.13.2 // indirect
github.com/cosmos/ledger-cosmos-go v0.12.4 // indirect
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[for reviewers] this was downgraded to match the version in celestiaorg/cosmos-sdk which matches the latest v0.46.x release of cosmos/cosmos-sdk.

Ref:

  1. https://github.com/celestiaorg/cosmos-sdk/pull/357/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R21
  2. https://github.com/cosmos/cosmos-sdk/blob/7799bba7bc889288607576aa11655b5fc31a2da9/go.mod#L21

@rootulp
Copy link
Collaborator Author

rootulp commented Nov 21, 2023

I'm happy we have a Ledger test that caught this! We still need more Ledger tests (i.e. for the pre-built binaries).

@rootulp rootulp enabled auto-merge (squash) November 21, 2023 22:07
cmwaters
cmwaters approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't mind merging this but It will probably be immediately overwritten by v1.20.0

@rootulp
Copy link
Collaborator Author

rootulp commented Nov 22, 2023

This PR is no longer necessary b/c #2860 (comment)

@rootulp rootulp closed this Nov 22, 2023
auto-merge was automatically disabled November 22, 2023 16:22

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmwaters cmwaters cmwaters approved these changes

@evan-forbes evan-forbes Awaiting requested review from evan-forbes

Assignees

@rootulp rootulp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rootulp @cmwaters