test: Benchmark MConnection with large size messages #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staheri14
added
WS: Big Blonks 🔭
rootulp
previously approved these changes
Jan 23, 2024
|
A fix is on the way for the failing Go Vulnerabilities checks. |
staheri14
added a commit
that referenced
this pull request
Jan 23, 2024
…heck (#1186) This PR addresses the vulnerabilities identified by govulncheck in [PR #1179](https://github.com/celestiaorg/celestia-core/actions/runs/7629759074/job/20786518441?pr=1179). It upgrades the affected modules to the versions recommended by govulncheck. ``` Vulnerability #1: GO-2024-2466 Denial of service in github.com/go-git/go-git/v5 and gopkg.in/src-d/go-git.v4 More info: https://pkg.go.dev/vuln/GO-2024-2466 Module: github.com/go-git/go-git/v5 Found in: github.com/go-git/go-git/[email protected] Fixed in: github.com/go-git/go-git/[email protected] Example traces found: Error: #1: test/e2e/generator/generate.go:402:36: generator.gitRepoLatestReleaseVersion calls git.PlainOpenWithOptions, which calls filesystem.NewStorage Error: #2: test/e2e/generator/generate.go:402:36: generator.gitRepoLatestReleaseVersion calls git.PlainOpenWithOptions Error: #3: test/e2e/generator/generate.go:407:30: generator.gitRepoLatestReleaseVersion calls git.Repository.TagObjects Vulnerability #2: GO-2024-2456 Path traversal and RCE in github.com/go-git/go-git/v5 and gopkg.in/src-d/go-git.v4 More info: https://pkg.go.dev/vuln/GO-2024-2456 Module: github.com/go-git/go-git/v5 Found in: github.com/go-git/go-git/[email protected] Fixed in: github.com/go-git/go-git/[email protected] Example traces found: Error: #1: test/e2e/generator/generate.go:402:36: generator.gitRepoLatestReleaseVersion calls git.PlainOpenWithOptions, which calls filesystem.NewStorage Error: #2: test/e2e/generator/generate.go:402:36: generator.gitRepoLatestReleaseVersion calls git.PlainOpenWithOptions Error: #3: test/e2e/generator/generate.go:407:30: generator.gitRepoLatestReleaseVersion calls git.Repository.TagObjects === Informational === There are 2 vulnerabilities in modules that you require that are neither imported nor called. You may not need to take any action. See https://pkg.go.dev/golang.org/x/vuln/cmd/govulncheck for details. Vulnerability #1: GO-2024-2453 Timing side channel in github.com/cloudflare/circl More info: https://pkg.go.dev/vuln/GO-2024-2453 Module: github.com/cloudflare/circl Found in: github.com/cloudflare/[email protected] Fixed in: github.com/cloudflare/[email protected] Vulnerability #2: GO-2023-[17](https://github.com/celestiaorg/celestia-core/actions/runs/7629759074/job/20786518441?pr=1179#step:5:18)65 Leaked shared secret and weak blinding in github.com/cloudflare/circl More info: https://pkg.go.dev/vuln/GO-[20](https://github.com/celestiaorg/celestia-core/actions/runs/7629759074/job/20786518441?pr=1179#step:5:21)23-1765 Module: github.com/cloudflare/circl Found in: github.com/cloudflare/[email protected] Fixed in: github.com/cloudflare/[email protected] Your code is affected by 2 vulnerabilities from 1 module. Share feedback at https://go.dev/s/govulncheck-feedback. exit status 3 make: *** [Makefile:254: vulncheck] Error 1 Error: Process completed with exit code 2. ```
evan-forbes
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR towards #1162
The aim of this benchmark is to assess the impact of the size of individual messages, particularly in relation to the MaxPacketMsgPayloadSize in the overall performance of MConnection as well as the ability to utilize the maximum bandwidth / send rate.