Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete blockchain/v2 until it gets simplified and stabilizes #309

Merged
merged 1 commit into from
May 3, 2021
Merged

Delete blockchain/v2 until it gets simplified and stabilizes #309

merged 1 commit into from
May 3, 2021

Conversation

liamsi
Copy link
Member

@liamsi liamsi commented May 2, 2021 •
edited
Loading

@liamsi liamsi force-pushed the ismail/remove_blockchainv2 branch from 83eca51 to 7ebe99b Compare May 2, 2021 09:55
@liamsi liamsi changed the title Delete blockchain/v2 until it get simplified and stabilizes Delete blockchain/v2 until it gets simplified and stabilizes May 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2021 •
edited
Loading

Codecov Report

Merging #309 (3a92a1f) into master (c48bd16) will increase coverage by 0.30%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
+ Coverage   61.79%   62.09%   +0.30%     
==========================================
  Files         270      262       -8     
  Lines       23895    23009     -886     
==========================================
- Hits        14765    14288     -477     
+ Misses       7591     7214     -377     
+ Partials     1539     1507      -32
Impacted Files Coverage Δ
config/toml.go 60.86% <ø> (ø)
node/node.go 55.02% <ø> (+0.30%) ⬆️
config/config.go 78.24% <100.00%> (+0.50%) ⬆️
crypto/sr25519/pubkey.go 43.47% <0.00%> (-8.70%) ⬇️
types/share_merging.go 73.85% <0.00%> (-1.31%) ⬇️
consensus/replay.go 70.53% <0.00%> (-0.83%) ⬇️
consensus/state.go 67.52% <0.00%> (-0.19%) ⬇️
consensus/reactor.go 77.10% <0.00%> (ø)
proxy/multi_app_conn.go 48.05% <0.00%> (ø)
blockchain/v0/reactor.go 63.96% <0.00%> (ø)
... and 3 more

@liamsi liamsi force-pushed the ismail/remove_blockchainv2 branch from 7ebe99b to 3a92a1f Compare May 2, 2021 10:10
@liamsi liamsi mentioned this pull request May 2, 2021
Closed
@liamsi liamsi marked this pull request as ready for review May 2, 2021 17:00
tac0turtle
tac0turtle approved these changes May 2, 2021
View reviewed changes
Copy link
Collaborator

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Utack.

evan-forbes
evan-forbes approved these changes May 3, 2021
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@liamsi liamsi merged commit cbf1f1a into master May 3, 2021
@liamsi liamsi deleted the ismail/remove_blockchainv2 branch May 3, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@evan-forbes evan-forbes evan-forbes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

blockchain: remove v2
4 participants
@liamsi @codecov-commenter @tac0turtle @evan-forbes