GetSharesByNamespace JSON RPC returns the the old representation of NamespacedShares

[oblique]

Celestia Node version

4b96022

OS

Arch Linux

Install tools

No response

Others

No response

Steps to reproduce it

Do share.GetSharesByNamespace request.

Expected result

I was expecting to get the new protobuf representation (share.p2p.shrex.nd.NamespaceRowResponse):

[
    {
      "shares": [],
      "proof": {
        "start": 1,
        "end": 2,
        "nodes": [
          "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABEinncqCRtmn9rQpzZu1bRShpoTh01mE75gkp9C68byu",
          "/////////////////////////////////////////////////////////////////////////////w81Htmj5E2p0vlhWgUHbEu+jHu0S74GbTWrHUPWC0NB"
        ],
        "leafHash": "AAAAAAAAAAAAAAAAAAAAAAAAAAwECTkh44s4pzQAAAAAAAAAAAAAAAAAAAAAAAAADAQJOSHjizinNErclwFCmkujstcQOiIunyB5edz+oREPWyE1GeDzvN9+",
        "isMaxNamespaceIgnored": true
      }
    }
]

Actual result

Instead I got the old representation (share.NamespacedShares):

[
    {
      "Shares": [],
      "Proof": {
        "start": 1,
        "end": 2,
        "nodes": [
          "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABEinncqCRtmn9rQpzZu1bRShpoTh01mE75gkp9C68byu",
          "/////////////////////////////////////////////////////////////////////////////w81Htmj5E2p0vlhWgUHbEu+jHu0S74GbTWrHUPWC0NB"
        ],
        "leaf_hash": "AAAAAAAAAAAAAAAAAAAAAAAAAAwECTkh44s4pzQAAAAAAAAAAAAAAAAAAAAAAAAADAQJOSHjizinNErclwFCmkujstcQOiIunyB5edz+oREPWyE1GeDzvN9+",
        "is_max_namespace_id_ignored": true
      }
    }
]

Relevant log output

No response

Notes

I think the issue starts from here.

[oblique]

Relevant issues: #2427, #2423.

Also in the new representation can you rename the fields in snake_case format?

[distractedm1nd]

Good catch, we will still return NamespacedShares but we will make the json fields match and be all in snake_case

[oblique]

Tested the latest release and I still get the old representation. I think this should be removed.

[distractedm1nd]

@oblique The protobuf definitions from nmt have now changed so that the fields are snake case - so your old actual result should be the new expected result. Or am I missing something?

[oblique]

I'm using ghcr.io/celestiaorg/celestia-node:v0.11.0-rc11 and when I request blob.GetProof I get this result:

{
  "jsonrpc": "2.0",
  "result": [
    {
      "end": 2,
      "is_max_namespace_id_ignored": true,
      "leaf_hash": null,
      "nodes": [
        "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABLdBzzpUnHG99n3rFul1zuDC3/mibQH8Ics9I1EP3muK",
        "/////////////////////////////////////////////////////////////////////////////yVANEGwvveNvq0ylhBwcRNmpTd/hLmgSlPtjrMfJSMj"
      ],
      "start": 1
    }
  ],
  "id": 4
}

The is_max_namespace_id_ignored is from the previous representation. If masrhialing was done by the new protobuf definition it should be is_max_namespace_ignored. I believe this is because the custom MarshalJSON was not replaced by the protobuf one. Instead of jsonProof it should marshal pb.Proof.

[distractedm1nd]

Yes, it should, didn't even catch that - thanks

[distractedm1nd]

related #2728