feat(share): collect absence proof if namespace is not present in merkle tree #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2242 +/- ##
==========================================
- Coverage 50.86% 50.73% -0.13%
==========================================
Files 154 154
Lines 9742 9810 +68
==========================================
+ Hits 4955 4977 +22
- Misses 4350 4398 +48
+ Partials 437 435 -2
|
Wondertan
reviewed
Jun 9, 2023
walldiss
force-pushed
the
non_inclusion_proofs
branch
from
cef381e to
8ad8381
Compare
Wondertan
previously approved these changes
Jun 14, 2023
distractedm1nd
previously approved these changes
Jun 14, 2023
renaynay
reviewed
Jun 14, 2023
- remove impossible if statement
distractedm1nd
previously approved these changes
Jun 15, 2023
Wondertan
previously approved these changes
Jun 15, 2023
renaynay
previously approved these changes
Jun 15, 2023
walldiss
dismissed stale reviews from renaynay, Wondertan, and distractedm1nd
via
f6cd31d
Wondertan
approved these changes
Jun 15, 2023
renaynay
approved these changes
Jun 15, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 22, 2023
## Overview This PR implements support for non-inclusion proof for getters and shrex protocol. Requires #2242 to be merged first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implements non-inclusion proof collector. Higher level integration (e.g. shrex) is coming as separate PR.